Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add vscode note to CONTRIBUTING.md #641

Open
wants to merge 1 commit into
base: delta
Choose a base branch
from

Conversation

rickstaa
Copy link
Member

What does this pull request do? Explain your changes. (required)

This commit adds a reference to VScode and the Hardhat extension in the
contribution guidelines. Feel free to close if this is not the recommended way of working with the codebase.

Specific updates (required)

  • Updated CONTRIBUTIN.md

How did you test each of these updates (required)

Not needed.

Does this pull request close any open issues?

No

Checklist:

  • README and other documentation updated
  • All tests using yarn test pass

This commit adds a reference to VScode and the Hardhat extension in the
contribution guidelines.
@yondonfu yondonfu requested a review from victorges April 15, 2024 18:32
Copy link
Member

@victorges victorges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a note, but the doc looks good


## Development Environment

For easy development, we recommend using [Visual Studio Code](https://code.visualstudio.com/) with the [Hardhat extension](https://hardhat.org/hardhat-vscode/docs/overview). This will provide you with syntax highlighting, code completion, debugging capabilities, and an easy-to-use test explorer.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a note that I've had mixed experiences with the VSCode Solidity extensions.

IIRC the official Solidity extension worked well for most things but navigating through the code ("go to implementation" kind of thing) and the Hardhat one fixed that but broke other things. Maybe it's because we previously didn't have a remappings.txt file, not sure.

If you are getting a clean dev xp with that setup, let's update this doc with it though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants