Use ffmpeg parser for H.264 #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a number of things including a LPMS crash, choppy video quality, green screens during rotation, inconsistent frame counts vs software decoding, etc. This is a massive change: we can no longer add outputs up front due to the ffmpeg hwaccel API, so we have to wait until we receive a decoded video frame in order to add outputs. This also means properly queuing up audio and draining things in the same order.
leszko
approved these changes
Jan 15, 2025
ffmpeg/nvidia_test.go
Outdated
| fname := dir + "/mpeg2.ts" | ||
| oname := dir + "/out.ts" | ||
| fname := dir + "/test.flv" | ||
| //oname := dir + "/out.ts" |
There was a problem hiding this comment.
Nit: Remove commented-out code
There was a problem hiding this comment.
Thanks for the spot, fixed and cleaned up in 9e51cee
j0sh
commented
Jan 16, 2025
| @@ -603,6 +603,7 @@ func TestNvidia_API_AlternatingTimestamps(t *testing.T) { | |||
| tc := NewTranscoder() | |||
| idx := []int{1, 0, 3, 2} | |||
| for _, i := range idx { | |||
| // TODO this breaks with nvidia acceleration on the input! | |||
There was a problem hiding this comment.
Note that this is not a new problem with this PR; the old code had the same issue
Maybe @emranemran you could take a look at the C code? Can't remember if you've reviewed much of lpms in the past.. |
mjh1
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a number of things with the nvidia built-in parser (cuvid) including a LPMS crash, choppy video quality, green screen flashing during rotation, inconsistent frame counts vs software decoding, etc. We also apparently gained GPU support for MPEG2 decoding.
This is a massive change: we can no longer add outputs up front due to the ffmpeg hwaccel API, so we have to wait until we receive a decoded video frame in order to add outputs. This also means properly queuing up audio and draining things in the same order.
This also unfortunately adds ~13 MB of new samples to the repo for test cases, since these are hard to generate synthetically.