install_ffmpeg: Add FLV muxer #428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests are still broken in CI but pass locally |
victorges
approved these changes
Dec 2, 2024
| @@ -205,7 +205,7 @@ fi | |||
|
|
|||
| if [[ $BUILD_TAGS == *"debug-video"* ]]; then | |||
| echo "video debug mode, building ffmpeg with tools, debug info and additional capabilities for running tests" | |||
| DEV_FFMPEG_FLAGS="--enable-muxer=md5,flv --enable-demuxer=hls --enable-filter=ssim,tinterlace --enable-encoder=wrapped_avframe,pcm_s16le " | |||
There was a problem hiding this comment.
Why remove this one? Are those only extra from the non-dev ones?
There was a problem hiding this comment.
Yes, the base configuration includes flv now, so specifying it (again) with the dev flags isn't necessary (trying to keep things tidy)
j0sh
added a commit
to livepeer/go-livepeer
that referenced
this pull request
Dec 3, 2024
Updates LPMS to use the FLV muxer introduced in livepeer/lpms#428 which should resolve issues with getting RTMP output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make RTMP output work on production (non-debug) builds of LPMS