Update ffmpeg.go change preset from slow to medium #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Going from 2 pass encode slow preset to medium preset.
j0sh
approved these changes
Nov 21, 2024
|
LGTM but would also like input from @leszko since he is the one who made the original change to improve quality Also wanted to confirm that this does result in a measurable speedup for GPU with our benchmark tools? |
Yes it does, performance hit with slow is over 50%: |
leszko
approved these changes
Nov 22, 2024
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the FFmpeg preset from slow to medium because the increased computation time required for slow does not provide a significant visual quality improvement. This change optimizes the balance between performance and quality.
