Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cross-compilation by compiling zlib from source #425

Merged
merged 2 commits into from
Oct 17, 2024
Merged

Fix cross-compilation by compiling zlib from source #425

merged 2 commits into from
Oct 17, 2024

Conversation

leszko
Copy link
Contributor

@leszko leszko commented Oct 16, 2024

No description provided.

@leszko leszko requested review from j0sh and rickstaa October 16, 2024 15:51
@leszko leszko marked this pull request as ready for review October 16, 2024 15:51
@j0sh j0sh mentioned this pull request Oct 16, 2024
Merged
@leszko leszko merged commit ffde232 into master Oct 17, 2024
2 of 3 checks passed
@leszko leszko deleted the rafal/compile-zlib-from-source branch October 17, 2024 07:27
@rickstaa
Copy link
Member

rickstaa commented Oct 17, 2024 •
edited
Loading

@leszko, it’s not a huge issue, but I haven’t approved it yet because the tests are still failing. I tried re-running them, but the problem persists. Do you have any idea what might be causing this? It seems to have been happening on the main branch for a while now: https://github.com/livepeer/lpms/actions/workflows/build.yaml. I haven’t had a chance to dig into it myself yet.
cc. @j0sh

@leszko
Copy link
Contributor Author

leszko commented Oct 17, 2024

@leszko, it’s not a huge issue, but I haven’t approved it yet because the tests are still failing. I tried re-running them, but the problem persists. Do you have any idea what might be causing this? It seems to have been happening on the main branch for a while now: https://github.com/livepeer/lpms/actions/workflows/build.yaml. I haven’t had a chance to dig into it myself yet. cc. @j0sh

It's not related to this PR. master was failing as well. No idea why 🤷

@rickstaa
Copy link
Member

@leszko, it’s not a huge issue, but I haven’t approved it yet because the tests are still failing. I tried re-running them, but the problem persists. Do you have any idea what might be causing this? It seems to have been happening on the main branch for a while now: https://github.com/livepeer/lpms/actions/workflows/build.yaml. I haven’t had a chance to dig into it myself yet. cc. @j0sh

It's not related to this PR. master was failing as well. No idea why 🤷

Yea I saw let's tackle that later 👍🏻.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j0sh j0sh j0sh approved these changes

@rickstaa rickstaa Awaiting requested review from rickstaa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leszko @rickstaa @j0sh