Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ffmpeg: Add a metadata option to each output #421

Merged
merged 2 commits into from
Sep 9, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ffmpeg/encoder.c
Original file line number Diff line number Diff line change
Expand Up @@ -286,6 +286,8 @@ int open_output(struct output_ctx *octx, struct input_ctx *ictx)
if (ret < 0) LPMS_ERR(open_output_err, "Error opening output file");
}

if (octx->metadata) av_dict_copy(&oc->metadata, octx->metadata, 0);

ret = avformat_write_header(oc, &octx->muxer->opts);
if (ret < 0) LPMS_ERR(open_output_err, "Error writing header");

Expand Down
7 changes: 6 additions & 1 deletion ffmpeg/ffmpeg.go
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,7 @@ type TranscodeOptions struct {
Muxer ComponentOptions
VideoEncoder ComponentOptions
AudioEncoder ComponentOptions
Metadata map[string]string
}

type MediaInfo struct {
Expand Down Expand Up @@ -778,6 +779,7 @@ func createCOutputParams(input *TranscodeOptionsIn, ps []TranscodeOptions) ([]C.
name: C.CString(audioEncoder),
opts: newAVOpts(p.AudioEncoder.Opts),
}
metadata := newAVOpts(p.Metadata)
fromMs := int(p.From.Milliseconds())
toMs := int(p.To.Milliseconds())
vfilt := C.CString(filters)
Expand All @@ -786,7 +788,7 @@ func createCOutputParams(input *TranscodeOptionsIn, ps []TranscodeOptions) ([]C.
params[i] = C.output_params{fname: oname, fps: fps,
w: C.int(w), h: C.int(h), bitrate: C.int(bitrate),
gop_time: C.int(gopMs), from: C.int(fromMs), to: C.int(toMs),
muxer: muxOpts, audio: audioOpts, video: vidOpts,
muxer: muxOpts, audio: audioOpts, video: vidOpts, metadata: metadata,
vfilters: vfilt, sfilters: nil, xcoderParams: xcoderOutParams}
if p.CalcSign {
//signfilter string
Expand Down Expand Up @@ -841,6 +843,9 @@ func destroyCOutputParams(params []C.output_params) {
if p.video.opts != nil {
C.av_dict_free(&p.video.opts)
}
if p.metadata != nil {
C.av_dict_free(&p.metadata)
}
}
}

Expand Down
9 changes: 8 additions & 1 deletion ffmpeg/ffmpeg_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -1628,6 +1628,9 @@ func TestTranscoder_FormatOptions(t *testing.T) {
Oname: dir + "/test.flv",
VideoEncoder: ComponentOptions{Name: "copy"},
AudioEncoder: ComponentOptions{Name: "copy"},
Metadata: map[string]string{
"encoded_by": "Livepeer Media Server",
},
}}
if out[0].Profile.Format != FormatNone {
t.Error("Expected empty profile for output option")
Expand All @@ -1637,7 +1640,7 @@ func TestTranscoder_FormatOptions(t *testing.T) {
t.Error(err)
}
cmd = `
ffprobe -loglevel warning -show_format test.flv | grep format_name=flv
ffprobe -loglevel warning -show_format test.flv | grep 'format_name=flv\|encoded_by=Livepeer Media Server'
`
run(cmd)

Expand All @@ -1646,6 +1649,9 @@ func TestTranscoder_FormatOptions(t *testing.T) {
out[0].Muxer = ComponentOptions{Name: "hls", Opts: map[string]string{
"hls_segment_filename": dir + "/test_segment_%d.ts",
}}
out[0].Metadata = map[string]string{
"service_provider": "Livepeer Media Server",
}
_, err = Transcode3(in, out)
if err != nil {
t.Error(err)
Expand All @@ -1660,6 +1666,7 @@ func TestTranscoder_FormatOptions(t *testing.T) {
ffprobe -loglevel warning -show_entries format=format_name,duration test.ts > test.out
diff -u segment.out test.out
wc -l test.out | grep 4 # sanity check output file length
ffprobe segment.ts 2>&1 | grep 'service_provider: Livepeer Media Server'
`
run(cmd)

Expand Down
1 change: 1 addition & 0 deletions ffmpeg/filter.h
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ struct output_ctx {
component_opts *muxer;
component_opts *video;
component_opts *audio;
AVDictionary *metadata;

int64_t drop_ts; // preroll audio ts to drop

Expand Down
1 change: 1 addition & 0 deletions ffmpeg/transcoder.c
Original file line number Diff line number Diff line change
Expand Up @@ -216,6 +216,7 @@ int transcode_init(struct transcode_thread *h, input_params *inp,
octx->muxer = &params[i].muxer;
octx->audio = &params[i].audio;
octx->video = &params[i].video;
octx->metadata = params[i].metadata;
octx->vfilters = params[i].vfilters;
octx->sfilters = params[i].sfilters;
octx->xcoderParams = params[i].xcoderParams;
Expand Down
1 change: 1 addition & 0 deletions ffmpeg/transcoder.h
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ typedef struct {
component_opts muxer;
component_opts audio;
component_opts video;
AVDictionary *metadata;
} output_params;

typedef struct {
Expand Down
Loading