Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove scene detection code #377

Merged
merged 12 commits into from
Jan 15, 2024
Merged

Remove scene detection code #377

merged 12 commits into from
Jan 15, 2024

Conversation

thomshutt
Copy link
Contributor

This is no longer needed and so is being removed to make the code more managable

@thomshutt thomshutt requested a review from leszko January 12, 2024 13:32
Copy link
Contributor

@leszko leszko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work @thomshutt . Looks great to remove soo much unused comment.

One question, do we maybe want to check if it still works fine on an Nvidia machine?

@thomshutt
Copy link
Contributor Author

@leszko I've been running a version of go-livepeer with this LPMS commit and it seems fine

@thomshutt thomshutt merged commit 98566e2 into master Jan 15, 2024
1 check failed
@thomshutt thomshutt deleted the remove-detection branch January 15, 2024 10:31
thomshutt added a commit that referenced this pull request Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants