Use fuzzy pixel matching in local verification #2738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@thomshutt please arrange reviewing this and livepeer/lpms#366 to enable local verification. |
|
Hey @cyberj0g, it looks like the build is still failing here |
|
@thomshutt it will not work, until lpms PR is merged |
|
@cyberj0g Oof, gotcha. Looks like the LPMS build is broken too for that PR, so we'll have to try and figure out what's going on there first |
|
@thomshutt I mean this one, not Alex's wrongly mentioned in description: livepeer/lpms#366 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
Fix for: #2649
Specific updates (required)
This PR is mostly refactoring and adding some fields to support corresponding LPMS changes: livepeer/lpms#366
How did you test each of these updates (required)
Tests are updated.
Does this pull request close any open issues?
#2649
Edit: originally wrong corresponding LPMS PR was mentioned