Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tweak cuda install_ffmpeg parameters, remove build-time cuda dependency #1207

Merged
merged 1 commit into from
Nov 21, 2019
Merged

tweak cuda install_ffmpeg parameters, remove build-time cuda dependency #1207

merged 1 commit into from
Nov 21, 2019

Conversation

iameli
Copy link
Contributor

@iameli iameli commented Nov 21, 2019 •
edited
Loading

just a little build fix, discussion in #1124

edit: whoops, CUDA wasn't detected at all in this build, please hold...

@iameli iameli changed the title build cuda with llvm wip broken: build cuda with llvm Nov 21, 2019
@iameli iameli changed the title wip broken: build cuda with llvm build cuda with llvm, remove build-time cuda dependency Nov 21, 2019
@j0sh
Copy link
Collaborator

j0sh commented Nov 21, 2019

Nice! Feel free to adjust the base branch here to ja/cuda which updates ffmpeg itself and makes some of the configure-time options a bit more explicit. Trying to keep things outside of #1124 as much as possible.

@iameli
add clang to build process for cuda, remove build-time dependency
1ebcc10 
switched to the llvm method of building cuda. apparently we don't even
need cuda as a build-time dependency, now? that's pretty neat.
@iameli iameli changed the base branch from ja/lb to ja/cuda November 21, 2019 18:53
@iameli iameli changed the title build cuda with llvm, remove build-time cuda dependency tweak cuda install_ffmpeg parameters, remove build-time cuda dependency Nov 21, 2019
@iameli iameli requested a review from j0sh November 21, 2019 18:54
@iameli
Copy link
Contributor Author

iameli commented Nov 21, 2019

@j0sh Done!

@j0sh j0sh merged commit 719d807 into ja/cuda Nov 21, 2019
@j0sh j0sh deleted the eli/lb-llvm-build branch November 21, 2019 19:12
@j0sh
Copy link
Collaborator

j0sh commented Nov 21, 2019

Thanks!

@j0sh j0sh mentioned this pull request Nov 21, 2019
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j0sh j0sh Awaiting requested review from j0sh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iameli @j0sh