feat: make delegation widget accessible from My Account view when wallet is connected #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@adamsoffer, thanks again for implementing this ❤️🔥. I tested the changes, and they are working on my local machine. I think the code is cleanly executed and can be merged. However, I made one small suggestion that could improve the mobile delegate/undelegated behaviour (see #255). Your old versions would only show the delegate button on the mobile view:
The new behavoir shows both buttons and opens the related delegator widget tab accordingly:
|
…ir (#255) This commit ensures that both delegate and undelegate buttons are shown on mobile devices and that the right tab of the delegation widget is opened when clicking on these buttons.
|
Thanks @rickstaa! Nice spot - just merged your PR into this branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that the delegation widget is accessible from the "My Account" view when a user's wallet is connected to the explorer. Resolves issue #243