add static ffmpeg #711
Closed
add static ffmpeg #711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
iameli-streams
commented
Oct 19, 2023
•
iameli-streams
commented
- Adds the ability for the downloader to download "raw" binaries (plz look @hjpotter92)
- Adds a statically-linked ffmpeg version 6 (plz look @mjh1)
iameli-streams
force-pushed
the
eli/static-ffmpeg
branch
from
aa7937a to
9bf6d55
Compare
mjh1
approved these changes
Oct 20, 2023
mjh1
reviewed
Oct 20, 2023
| darwin-amd64: ffmpeg-darwin-x64 | ||
| darwin-arm64: ffmpeg-darwin-arm64 | ||
| outputPath: ffmpeg | ||
| skipManifestUpdate: true |
There was a problem hiding this comment.
Please could you add ffprobe in too so they're on the same version?
There was a problem hiding this comment.
Then I guess we can remove installing ffmpeg from apt?
There was a problem hiding this comment.
creating a cyclic loop: iameli-streams#2 :D
There was a problem hiding this comment.
Just merged, that PR, will merge this one when CI passes
There was a problem hiding this comment.
I'm wondering whether the CI test failures are because of removing the ffmpeg apt install 😕
Tried to prove that with iameli-streams#3
@iameli @hjpotter92
|
In the end this was done with https://github.com/livepeer/catalyst/pull/721/files |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.