upload: add TeeReader to count bytes during upload #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We occasionally see an EOF error when attempting to upload to S3 storage. An EOF from io.ReadCloser interfaces typically indicates that no more input is available. This commit is adding a TeeReader to count the number of bytes that were read from the local input file when attempting to upload -- this should help us diagnose upload errors where segments seem to be missing from s3 buckets.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #54 +/- ##
===================================================
- Coverage 16.85393% 16.84783% -0.00610%
===================================================
Files 2 2
Lines 178 184 +6
===================================================
+ Hits 30 31 +1
- Misses 140 145 +5
Partials 8 8
Continue to review full report in Codecov by Sentry.
|
mjh1
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We occasionally see an EOF error when attempting to upload to S3 storage. An EOF from io.ReadCloser interfaces typically indicates that no more input is available. This commit is adding a TeeReader to count the number of bytes that were read from the local input file when attempting to upload -- this should help us diagnose upload errors where segments seem to be missing from s3 buckets.