Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add URI to logs and errors for better debugging #52

Merged
merged 3 commits into from
Jan 30, 2024
Merged

Add URI to logs and errors for better debugging #52

merged 3 commits into from
Jan 30, 2024

Conversation

mjh1
Copy link
Contributor

@mjh1 mjh1 commented Jan 25, 2024

No description provided.

@mjh1 mjh1 requested review from thomshutt and emranemran January 25, 2024 16:11
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

Attention: 35 lines in your changes are missing coverage. Please review.

Comparison is base (fd91c08) 17.68293% compared to head (b97d642) 14.04494%.

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##                main         #52         +/-   ##
===================================================
- Coverage   17.68293%   14.04494%   -3.63799%     
===================================================
  Files              2           2                 
  Lines            164         178         +14     
===================================================
- Hits              29          25          -4     
- Misses           127         146         +19     
+ Partials           8           7          -1     
Files Coverage Δ
core/uploader.go 19.68504% <20.00000%> (-3.51496%) ⬇️
catalyst-uploader.go 0.00000% <0.00000%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd91c08...b97d642. Read the comment docs.

Files Coverage Δ
core/uploader.go 19.68504% <20.00000%> (-3.51496%) ⬇️
catalyst-uploader.go 0.00000% <0.00000%> (ø)

@thomshutt
Copy link
Contributor

Are these logs going to have credentials in? Do we need to think about redacting?

@mjh1
Copy link
Contributor Author

mjh1 commented Jan 26, 2024

Are these logs going to have credentials in? Do we need to think about redacting?

I had seen that somehow they're getting redacted by something sitting above the uploader.. but i'll play it safe and redact here!

@mjh1 mjh1 requested review from thomshutt and removed request for thomshutt January 30, 2024 11:18
@mjh1
Copy link
Contributor Author

mjh1 commented Jan 30, 2024

@thomshutt Ready for review now 🙏

@mjh1 mjh1 merged commit eecd216 into main Jan 30, 2024
10 checks passed
@mjh1 mjh1 deleted the mh/log branch January 30, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants