Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump recording object ttl to 10 days #45

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Bump recording object ttl to 10 days #45

merged 1 commit into from
Nov 17, 2023

Conversation

mjh1
Copy link
Contributor

@mjh1 mjh1 commented Nov 15, 2023

Bump this while we're in the process of fixing various recording issues

Bump this while we're in the process of fixing various recording issues
@mjh1 mjh1 requested a review from thomshutt November 15, 2023 08:26
Copy link

codecov bot commented Nov 15, 2023

Codecov Report

Merging #45 (355dcf8) into main (7e5e1fe) will not change coverage.
The diff coverage is 0.00000%.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##                main         #45   +/-   ##
=============================================
  Coverage   16.14907%   16.14907%           
=============================================
  Files              2           2           
  Lines            161         161           
=============================================
  Hits              26          26           
  Misses           126         126           
  Partials           9           9           
Files Coverage Δ
core/uploader.go 20.80000% <0.00000%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e5e1fe...355dcf8. Read the comment docs.

Files Coverage Δ
core/uploader.go 20.80000% <0.00000%> (ø)

@thomshutt thomshutt merged commit 549ad12 into main Nov 17, 2023
10 checks passed
@thomshutt thomshutt deleted the mh/bump-ttl branch November 17, 2023 11:26
mjh1 added a commit that referenced this pull request Nov 29, 2023
This reverts commit 549ad12.

We should use the option on the access keys instead, and then remove
this hack.
mjh1 added a commit that referenced this pull request Nov 29, 2023
This reverts commit 549ad12.

We should use the option on the access keys instead, and then remove
this hack.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants