Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove staging from the hack #34

Merged
merged 1 commit into from
Sep 25, 2023
Merged

Remove staging from the hack #34

merged 1 commit into from
Sep 25, 2023

Conversation

mjh1
Copy link
Contributor

@mjh1 mjh1 commented Sep 22, 2023

We have the new feature now to set ttls so I'm removing in staging to verify it works properly

We have the new feature now to set ttls so I'm removing in staging to verify it works properly
@mjh1 mjh1 requested a review from thomshutt September 22, 2023 14:44
@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Merging #34 (9c853a7) into main (0339ced) will decrease coverage by 0.80439%.
The diff coverage is 0.00000%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##                main         #34         +/-   ##
===================================================
- Coverage   29.21348%   28.40909%   -0.80439%     
===================================================
  Files              2           2                 
  Lines             89          88          -1     
===================================================
- Hits              26          25          -1     
  Misses            55          55                 
  Partials           8           8                 
Files Changed Coverage Δ
core/uploader.go 48.07692% <0.00000%> (-0.97968%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0339ced...9c853a7. Read the comment docs.

Files Changed Coverage Δ
core/uploader.go 48.07692% <0.00000%> (-0.97968%) ⬇️

@mjh1 mjh1 merged commit b299a0e into main Sep 25, 2023
10 checks passed
@mjh1 mjh1 deleted the mh/storj branch September 25, 2023 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants