Skip to content

Commit

Permalink
Set segment write timeout
Browse files Browse the repository at this point in the history
  • Loading branch information
mjh1 committed Jan 25, 2024
1 parent 58cf59f commit 2d73713
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion core/uploader.go
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@ func UploadRetryBackoff() backoff.BackOff {
return backoff.WithMaxRetries(newExponentialBackOffExecutor(), 3)
}

const segmentWriteTimeout = 5 * time.Minute

func Upload(input io.Reader, outputURI string, waitBetweenWrites, writeTimeout time.Duration) error {
storageDriver, err := drivers.ParseOSURL(outputURI, true)
if err != nil {
Expand Down Expand Up @@ -60,7 +62,7 @@ func Upload(input io.Reader, outputURI string, waitBetweenWrites, writeTimeout t
}

err = backoff.Retry(func() error {
_, err := session.SaveData(context.Background(), "", bytes.NewReader(fileContents), fields, writeTimeout)
_, err := session.SaveData(context.Background(), "", bytes.NewReader(fileContents), fields, segmentWriteTimeout)

Check warning on line 65 in core/uploader.go

View check run for this annotation

Codecov / codecov/patch

core/uploader.go#L65

Added line #L65 was not covered by tests
if err != nil {
glog.Errorf("failed upload attempt: %v", err)
}
Expand Down

0 comments on commit 2d73713

Please sign in to comment.