transmux: use stream based concatenation for clips #966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emranemran
force-pushed
the
emran/use-stream-based-concat
branch
from
6661ab8 to
fba854e
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #966 +/- ##
===================================================
+ Coverage 51.02313% 51.49385% +0.47072%
===================================================
Files 65 65
Lines 6744 6828 +84
===================================================
+ Hits 3441 3516 +75
+ Misses 3011 3009 -2
- Partials 292 303 +11
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
thomshutt
reviewed
Nov 9, 2023
thomshutt
reviewed
Nov 9, 2023
|
Updates:
|
Occasionally, the mp4s of very short clips might stutter as it crosses segment boundaries. This was caused by incorrect PTS between segments which in turn is a result of us clipping and re-encoding the first and last segments "locally". Using a stream based concatenation instead of file based concatenation readjusts the timestamps and prevents these issues. Note: Eventually, all mp4s will be generated using stream based concatenation if this works well for clipping.
* split out ffmpeg calls to stream-concat into it's own mini function to follow the existing styles in the video package * add deletion logic for all intermediary segment files
* All transmux ops used to happen within /tmp/transmux dir with unique request-id based filenames. To make this cleaner, we now generate a unique tmp folder per request where transmux ops are done. * Also added logic to do a deferred removal of this tmp dir for each request.
emranemran
force-pushed
the
emran/use-stream-based-concat
branch
2 times, most recently
from
32184c5 to
ffdfaa7
Compare
|
Updates:
|
emranemran
force-pushed
the
emran/use-stream-based-concat
branch
from
ffdfaa7 to
2619fd7
Compare
emranemran
force-pushed
the
emran/use-stream-based-concat
branch
from
2619fd7 to
266a888
Compare
mjh1
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Occasionally, the mp4s of very short clips might stutter as it crosses segment boundaries. This was caused by incorrect PTS between segments which in turn is a result of us clipping and re-encoding the first and last segments "locally". Using a stream based concatenation instead of file based concatenation readjusts the timestamps and prevents these issues.
Note: Eventually, all mp4s will be generated using stream based concatenation if this works well for clipping.