Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move setActive(true) from the trigger 'PUSH_REWRITE' to 'STREAM_BUFFER' #956

Merged
merged 3 commits into from
Nov 8, 2023

Conversation

leszko
Copy link
Contributor

@leszko leszko commented Nov 7, 2023

This should fix the idle stream issue in the scenario when the stream is started and suddenly stopped.

@leszko leszko requested review from iameli and thomshutt November 7, 2023 13:24
Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Merging #956 (5075f8f) into main (7b69661) will increase coverage by 0.06846%.
The diff coverage is 0.00000%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##                main        #956         +/-   ##
===================================================
+ Coverage   50.83682%   50.90528%   +0.06846%     
===================================================
  Files             65          65                 
  Lines           6692        6683          -9     
===================================================
  Hits            3402        3402                 
+ Misses          3002        2993          -9     
  Partials         288         288                 
Files Coverage Δ
mapic/mistapiconnector_app.go 18.92857% <0.00000%> (+0.29940%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b69661...5075f8f. Read the comment docs.

Files Coverage Δ
mapic/mistapiconnector_app.go 18.92857% <0.00000%> (+0.29940%) ⬆️

@leszko leszko merged commit 05a2b98 into main Nov 8, 2023
10 checks passed
@leszko leszko deleted the rafal/move-setactive-stream-buffer branch November 8, 2023 10:30
leszko added a commit that referenced this pull request Nov 9, 2023
leszko added a commit that referenced this pull request Nov 9, 2023
leszko added a commit that referenced this pull request Jan 15, 2024
…R' (#956)

* Move setActive(true) from the trigger 'PUSH_REWRITE' to 'STREAM_BUFFER'

* Add error context for calling setactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants