ffmpeg: ignore SPS warnings when probing segments #928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some input videos may not follow the h264 spec exactly - ffprobe/ffmpeg may throw warnings on such input but the videos can be decoded and played by all players. For these specific errors/warnings, we can ignore them but we also want to log other types of errors to keep track of all the different possible errors. See VID-450 for more details.
Codecov Report
@@ Coverage Diff @@
## main #928 +/- ##
===================================================
- Coverage 51.05068% 51.02703% -0.02365%
===================================================
Files 63 63
Lines 6472 6475 +3
===================================================
Hits 3304 3304
- Misses 2898 2901 +3
Partials 270 270
Continue to review full report in Codecov by Sentry.
|
mjh1
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some input videos may not follow the h264 spec exactly - ffprobe/ffmpeg may throw warnings on such input but the videos can be decoded and played by all players. For these specific errors/warnings, we can ignore them but we also want to log other types of errors to keep track of all the different possible errors. See VID-450 for more details.