Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable source playback for storj recordings #858

Merged
merged 1 commit into from
Sep 13, 2023
Merged

Enable source playback for storj recordings #858

merged 1 commit into from
Sep 13, 2023

Conversation

mjh1
Copy link
Contributor

@mjh1 mjh1 commented Sep 12, 2023

The hostname in the storj urls is not unique so had to switch this logic to a string substitution. I've confirmed this is working on staging.

@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Merging #858 (c3dd7b5) into main (7fc5223) will increase coverage by 0.06356%.
The diff coverage is 57.89474%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##                main        #858         +/-   ##
===================================================
+ Coverage   51.66228%   51.72584%   +0.06356%     
===================================================
  Files             63          63                 
  Lines           6076        6084          +8     
===================================================
+ Hits            3139        3147          +8     
  Misses          2685        2685                 
  Partials         252         252                 
Files Changed Coverage Δ
pipeline/ffmpeg.go 35.11450% <57.89474%> (+2.04363%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fc5223...c3dd7b5. Read the comment docs.

Files Changed Coverage Δ
pipeline/ffmpeg.go 35.11450% <57.89474%> (+2.04363%) ⬆️

@mjh1 mjh1 merged commit 506e24f into main Sep 13, 2023
12 checks passed
@mjh1 mjh1 deleted the mh/storj-recs branch September 13, 2023 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants