Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added ID field to analytics parsing #1354

Merged
merged 2 commits into from
Aug 7, 2024
Merged

Conversation

0xcadams
Copy link
Contributor

@0xcadams 0xcadams commented Aug 7, 2024

Added an ID field to the analytics logs, which is generated from the Player and passed through to CH.

@0xcadams 0xcadams requested review from victorges and leszko August 7, 2024 18:11
@0xcadams
Copy link
Contributor Author

0xcadams commented Aug 7, 2024

Copy link
Member

@victorges victorges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

handlers/analytics.go Outdated Show resolved Hide resolved
handlers/analytics_test.go Show resolved Hide resolved
handlers/analytics/log_processor.go Outdated Show resolved Hide resolved
@0xcadams 0xcadams merged commit f73e36e into main Aug 7, 2024
11 checks passed
@0xcadams 0xcadams deleted the 0xcadams/id-field-analytics branch August 7, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants