New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache also errors when caching lapi.GetStreamByPlaybackID() #1346

Merged

leszko merged 1 commit into main from rafal/improve-stream-by-playback-id-caching

Jul 26, 2024

Contributor

leszko commented Jul 26, 2024 •

edited

Loading

@victorges made a good comment after I already merged #1342

don't we need to remove the e.stream != nil check from L35 and L47 if we want to cache errors?
https://github.com/livepeer/catalyst-api/pull/1339/files#diff-3ab4c68e5efa7f23725f338aae519ee0613c23dd471ecc3a45ac4f0488bd985cR35
i mean. we are caching errors. we're just not using that cache haha


          Cache also errors when caching lapi.GetStreamByPlaybackID()

d622ee6

Related to Victor's comment.

leszko requested review from thomshutt and victorges

July 26, 2024 06:51

thomshutt approved these changes

View reviewed changes

leszko merged commit 18a6ada into main

11 checks passed

leszko deleted the rafal/improve-stream-by-playback-id-caching branch

July 26, 2024 13:05

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet