Add 1s cache for lapi.GetStreamByPlaybackID() #1339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It causes the prod failure, because of the cascading failures
victorges
approved these changes
Jul 24, 2024
| "time" | ||
| ) | ||
|
|
||
| const lapiCacheDuration = 1 * time.Second |
There was a problem hiding this comment.
Do we need the latest version of a stream for any config that can be changed? Maybe this cache could be even higher
There was a problem hiding this comment.
Not sure. I'm just afraid to set it higher (and 1s is enough for what we encountered)
| stream, err := a.lapi.GetStreamByPlaybackID(playbackId) | ||
| a.streamCache[playbackId] = entry{ | ||
| stream: stream, | ||
| err: err, |
There was a problem hiding this comment.
do we need to cache error cases if we only use cache when it's successful? Could be clearer to have an early return for err != nil here instead and skip the err in cache
There was a problem hiding this comment.
We do want to cache errors as well. That was actually the root cause of the issue that we never cached failed requests so they piled up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It causes the prod failure, because of the cascading failures
Related Discord thread: https://discord.com/channels/423160867534929930/1265176750544130068/1265181494763327562