Add logging about reason for not generating an MP4 #1335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomshutt
commented
Jul 22, 2024
| si.SignedSourceURL = signedNewSourceURL // http(s) URL used by mediaconvert | ||
| log.AddContext(p.RequestID, "signed_url", si.SignedSourceURL) |
There was a problem hiding this comment.
Refactor: Moved these to line up with the places where we get the info
thomshutt
commented
Jul 22, 2024
| } | ||
|
|
||
| return false | ||
| return true, "" |
There was a problem hiding this comment.
Flipped the logic to make it more of a standard Golang flow of error checking and then success
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there's no way of distinguishing between the different reasons when MP4 generation doesn't happen and so this extra logging means we will now always be able to differentiate.