Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pipeline: ffmpeg: probe and update width/height for recording inputs #1124

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

emranemran
Copy link
Collaborator

No description provided.

@emranemran emranemran requested review from thomshutt and mjh1 February 2, 2024 02:24
Copy link

codecov bot commented Feb 2, 2024

Codecov Report

Attention: 39 lines in your changes are missing coverage. Please review.

Comparison is base (7ffcd02) 52.44773% compared to head (d6d9c8b) 52.18346%.
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##                main       #1124         +/-   ##
===================================================
- Coverage   52.44773%   52.18346%   -0.26427%     
===================================================
  Files             70          70                 
  Lines           7701        7740         +39     
===================================================
  Hits            4039        4039                 
- Misses          3341        3380         +39     
  Partials         321         321                 
Files Coverage Δ
pipeline/ffmpeg.go 30.76923% <0.00000%> (-3.84615%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ffcd02...d6d9c8b. Read the comment docs.

Files Coverage Δ
pipeline/ffmpeg.go 30.76923% <0.00000%> (-3.84615%) ⬇️

Copy link
Contributor

@thomshutt thomshutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but needs tests

@emranemran emranemran force-pushed the emran/recording-fix-redux branch from 865c30f to d6d9c8b Compare February 2, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants