Make sure we close all http.Response and io.ReadCloser objs (#1275)

* Close several http.Response bodies that were forgotten

Found using https://github.com/timakin/bodyclose

* Close all files read with clients.GetFile

* Close remaining io.ReadCloser I could find

balancer/mist/mist_balancer.go

@@ -167,6 +167,7 @@ func (b *MistBalancer) changeLoadBalancerServers(ctx context.Context, server, ac
 		glog.Errorf("Error making request: %v", err)
 		return nil, err
 	}
+	defer resp.Body.Close()
 
 	bytes, err := io.ReadAll(resp.Body)
 
@@ -202,6 +203,7 @@ func (b *MistBalancer) getMistLoadBalancerServers(ctx context.Context) (map[stri
 		glog.Errorf("Error making request: %v", err)
 		return nil, err
 	}
+	defer resp.Body.Close()
 
 	if resp.StatusCode != http.StatusOK {
 		b, _ := io.ReadAll(resp.Body)

clients/broadcaster_remote.go

@@ -84,6 +84,8 @@ func findBroadcaster(c Credentials) (BroadcasterList, error) {
 	if err != nil {
 		return BroadcasterList{}, fmt.Errorf("http do(%s): %v", requestURL, err)
 	}
+	defer res.Body.Close()
+
 	if !httpOk(res.StatusCode) {
 		return BroadcasterList{}, fmt.Errorf("http GET(%s) returned %d %s", requestURL, res.StatusCode, res.Status)
 	}
@@ -124,6 +126,8 @@ func CreateStream(c Credentials, streamName string, profiles []video.EncodedProf
 	if err != nil {
 		return "", fmt.Errorf("http do(%s): %v", requestURL, err)
 	}
+	defer res.Body.Close()
+
 	if !httpOk(res.StatusCode) {
 		return "", fmt.Errorf("http POST(%s) returned %d %s", requestURL, res.StatusCode, res.Status)
 	}
@@ -156,6 +160,7 @@ func ReleaseManifestID(c Credentials, manifestId string) error {
 	if err != nil {
 		return fmt.Errorf("Releasing Manifest ID failed. URL: %s, manifestID: %s, err: %s", requestURL, manifestId, err)
 	}
+	defer res.Body.Close()
 
 	if !httpOk(res.StatusCode) {
 		return fmt.Errorf("Releasing Manifest ID failed. URL: %s, manifestID: %s, HTTP Code: %s", requestURL, manifestId, res.Status)

clients/input_copy.go

@@ -126,6 +126,9 @@ func getSignedURL(osTransferURL *url.URL) (string, error) {
 	signedURL := httpURL.String()
 
 	resp, err := http.Head(signedURL)
+	if resp != nil {
+		resp.Body.Close()
+	}
 	if err == nil && resp.StatusCode >= http.StatusOK && resp.StatusCode < http.StatusBadRequest {
 		return signedURL, nil
 	}
@@ -253,7 +256,8 @@ func CopyFileWithDecryption(ctx context.Context, sourceURL, destOSBaseURL, filen
 			if err != nil {
 				return fmt.Errorf("error decrypting file: %w", err)
 			}
-			c = io.NopCloser(decryptedFile)
+			defer decryptedFile.Close()
+			c = decryptedFile
 		}
 
 		content := io.TeeReader(c, &byteAccWriter)

clients/manifest.go

@@ -42,6 +42,8 @@ func DownloadRenditionManifest(requestID, sourceManifestOSURL string) (m3u8.Medi
 		if err != nil {
 			return fmt.Errorf("error downloading manifest: %s", err)
 		}
+		defer rc.Close()
+
 		playlist, playlistType, err = m3u8.DecodeFrom(rc, true)
 		if err != nil {
 			return fmt.Errorf("error decoding manifest: %s", err)
@@ -276,12 +278,13 @@ func ClipInputManifest(requestID, sourceURL, clipTargetUrl string, startTimeUnix
 			if err != nil {
 				return fmt.Errorf("error clipping: failed to download segment %d: %w", v.SeqId, err)
 			}
+			defer rc.Close()
+
 			// Write the segment data to the temp local file
 			_, err = io.Copy(clipSegmentFile, rc)
 			if err != nil {
 				return fmt.Errorf("error clipping: failed to write segment %d: %w", v.SeqId, err)
 			}
-			rc.Close()
 			return nil
 		}, DownloadRetryBackoff())
 		if err != nil {

handlers/geolocation/geolocation.go

@@ -317,9 +317,12 @@ func (c *GeolocationHandlersCollection) sendPlaybackRequestAsync(playbackID stri
 
 	go func() {
 		url := fmt.Sprintf("%s/hls/%s+%s/index.m3u8", m.Tags["https"], c.Config.MistBaseStreamName, playbackID)
-		if _, err := http.Get(url); err != nil {
+		resp, err := http.Get(url)
+		if err != nil {
 			glog.Errorf("Error making a playback request url=%s, err=%v", url, err)
+			return
 		}
+		resp.Body.Close()
 	}()
 }
 

mapic/utils/seekinghttp.go

@@ -206,6 +206,7 @@ func (s *SeekingHTTP) Size() (int64, error) {
 	if err != nil {
 		return 0, err
 	}
+	defer resp.Body.Close()
 
 	if resp.ContentLength < 0 {
 		return 0, errors.New("no content length for Size()")

thumbnails/thumbnails.go

@@ -40,6 +40,8 @@ func getMediaManifest(requestID string, input string) (*m3u8.MediaPlaylist, erro
 	if err != nil {
 		return nil, fmt.Errorf("error downloading manifest: %w", err)
 	}
+	defer rc.Close()
+
 	manifest, playlistType, err := m3u8.DecodeFrom(rc, true)
 	if err != nil {
 		return nil, fmt.Errorf("failed to decode manifest: %w", err)
@@ -95,7 +97,10 @@ func GenerateThumbsVTT(requestID string, input string, output *url.URL) error {
 		}
 		// check thumbnail file exists on storage
 		err = backoff.Retry(func() error {
-			_, err := clients.GetFile(context.Background(), requestID, outputLocation.JoinPath(filename).String(), nil)
+			rc, err := clients.GetFile(context.Background(), requestID, outputLocation.JoinPath(filename).String(), nil)
+			if rc != nil {
+				rc.Close()
+			}
 			return err
 		}, thumbWaitBackoff)
 		if err != nil {
@@ -199,6 +204,8 @@ func GenerateThumbsFromManifest(requestID, input string, output *url.URL) error
 			if err != nil {
 				return fmt.Errorf("error downloading manifest: %w", err)
 			}
+			defer rc.Close()
+
 			bs, err := io.ReadAll(rc)
 			if err != nil {
 				return err

transcode/transcode.go

@@ -5,7 +5,6 @@ import (
 	"bytes"
 	"context"
 	"fmt"
-	"github.com/grafov/m3u8"
 	"math"
 	"net/url"
 	"os"
@@ -14,6 +13,8 @@ import (
 	"sync"
 	"time"
 
+	"github.com/grafov/m3u8"
+
 	"github.com/cenkalti/backoff/v4"
 	c2pa2 "github.com/livepeer/catalyst-api/c2pa"
 	"github.com/livepeer/catalyst-api/clients"
@@ -538,6 +539,7 @@ func transcodeSegment(
 		if err != nil {
 			return fmt.Errorf("failed to download source segment %q: %s", segment.Input, err)
 		}
+		defer rc.Close()
 
 		// If an AccessToken is provided via the request for transcode, then use remote Broadcasters.
 		// Otherwise, use the local harcoded Broadcaster.