Skip to content

Commit

Permalink
transcode: Make sure we propagate not found err upstream
Browse files Browse the repository at this point in the history
Otherwise the backoff retry loop wouldn't stop.

This was the only use of clients.GetFile that wasn't wrapping
the error properly.
  • Loading branch information
victorges committed Jun 20, 2024
1 parent 51a0a07 commit 3bbdb4a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion transcode/transcode.go
Original file line number Diff line number Diff line change
Expand Up @@ -538,7 +538,7 @@ func transcodeSegment(
defer cancel()
rc, err := clients.GetFile(ctx, transcodeRequest.RequestID, segment.Input.URL.String(), nil)
if err != nil {
return fmt.Errorf("failed to download source segment %q: %s", segment.Input, err)
return fmt.Errorf("failed to download source segment %q: %w", segment.Input, err)
}
defer rc.Close()

Expand Down

0 comments on commit 3bbdb4a

Please sign in to comment.