update/ai runner image flag support refactor #398
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
rickstaa
commented
Jan 22, 2025
rickstaa
commented
- chore:add support for JSON string to defaultImage for overriding pipeline specific images in mappings
- chore:add docstring for overridePipelineImages function
- test:add test for overridePipelineImages function
- fix:malformed json test case handling;nits on expectedimage name
- test:add regular string input case
- refactor: update docstring placement to follow idiomatic Go convention
- refactor:optimise parsing func
- quick commit to show to victor
…line specific images in mappings
|
Replaced by #293. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.