Support for JSON string in defaultImage field for overriding pipeline specific images in the mappings #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickstaa
reviewed
Nov 30, 2024
worker/docker.go
Outdated
| @@ -97,6 +97,33 @@ type DockerManager struct { | |||
| mu *sync.Mutex | |||
| } | |||
|
|
|||
| func overridePipelineImages(defaultImage string) error { | |||
There was a problem hiding this comment.
@RUFFY-369 could you add a basic function docsting and tests?
There was a problem hiding this comment.
@rickstaa Thanks for the review! I just added the docstring and the test in the latest commits. 👍 🚀
Update:some nits were made in test for test failure due to logical error(change in pipeline names) and update func code for tackling malformed json case in the latest commit. Also added one more test case.
Rest is working smoothly with tests passing 👍
…line specific images in mappings
rickstaa
force-pushed
the
update/ai-runner-image-flag-support
branch
from
08e0bf9 to
ddfb96b
Compare
This was referenced Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards closing 'livepeer/bounties/#69
This PR adds support for processing JSON string in
defaultImageand specifies pipeline-specific images as key-value pairs with their mappings being updated to overridecontainerImage.go-livepeerPR which it supports is #3284cc @rickstaa