Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

worker,runner: Fix lifecycle management of realtime containers #288

Merged
merged 2 commits into from
Nov 25, 2024
Merged

worker,runner: Fix lifecycle management of realtime containers #288

merged 2 commits into from
Nov 25, 2024

Conversation

victorges
Copy link
Member

The shutdown logic needed some clean-up for the infer.py process, both internally and externally:

  • internally, we needed to cleanup some multiprocessing resources so the main process is allowed to exit
  • externally, we needed to use os._exit instead of sys.exit to exit the main app process

@victorges victorges requested a review from rickstaa as a code owner November 25, 2024 19:58
@victorges victorges requested a review from eliteprox November 25, 2024 20:18
eliteprox
eliteprox approved these changes Nov 25, 2024
View reviewed changes
Copy link
Collaborator

@eliteprox eliteprox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested on streamdiffusion

@victorges victorges merged commit e965eb7 into main Nov 25, 2024
9 checks passed
@victorges victorges deleted the vg/fix/realtime-lifecycle branch November 25, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eliteprox eliteprox eliteprox approved these changes

@rickstaa rickstaa Awaiting requested review from rickstaa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@victorges @eliteprox