-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SAM2 video-to-video real-time pipeline #280
Conversation
e7218c3
to
5bbae09
Compare
5bbae09
to
3792855
Compare
02a4fa1
to
b586552
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Only some minor nits
This reverts commit 3181235.
9486ab7
to
6b705eb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in segment_anything_2.py,
def update_params function, there is no exception handling or parmas validation, before applied the change, i.e recreate a model, with new params. what if it failed.
Params validation is handled by Sam2LiveParams which only accepts the fields and types defined there. Errors originating from
|
Adds segment-anything-2 support to the live-video-to-video pipeline, supporting the models
facebook/sam2-hiera-tiny
,facebook/sam2-hiera-small
andfacebook/sam2-hiera-large
.Start stream:
Update model parameters: