Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

live/infer: Add trickle input and output #253

Merged
merged 14 commits into from
Nov 2, 2024
Merged

live/infer: Add trickle input and output #253

merged 14 commits into from
Nov 2, 2024

Conversation

j0sh
Copy link
Contributor

@j0sh j0sh commented Oct 30, 2024

Logging is still rough as I'm ironing out issues around tear-down, but wanted to put this out

Should be testable with

 curl -vvv http://localhost:9000/live-video-to-video/ -H 'Content-Type: application/json' -d '{"subscribe_url":"http://trickle-server/input-stream","publish_url":"http://trickle-server/output-stream"}'

@j0sh j0sh force-pushed the ja/add-pubsub-params branch from 0c77152 to 0775e8e Compare October 30, 2024 19:55
Base automatically changed from ja/add-pubsub-params to main October 30, 2024 23:17
@j0sh j0sh force-pushed the ja/add-trickle branch 2 times, most recently from 21a64c5 to a9c3af1 Compare October 31, 2024 08:59
@j0sh
Copy link
Contributor Author

j0sh commented Oct 31, 2024

@victorges Just a heads up that the publish task hangs after the input stream completes. I am not sure exactly how the other parts work but you will need to call publish_queue.put(None) after receiving a None from subscribe_queue (or waiting for subscribe task completion, eg await subscribe_task that is created here. This can also be used as a signal to clean up the inference job.

For reference, here is how I have been driving the process (without inference)

@victorges victorges changed the title Add trickle input and output live/infer: Add trickle input and output Nov 1, 2024
@victorges victorges marked this pull request as ready for review November 1, 2024 19:56
@victorges victorges requested a review from rickstaa as a code owner November 1, 2024 19:56
victorges and others added 5 commits November 1, 2024 17:22
- Make sure queue.get was done in a thread not to block asyncio loop
- Install libx264 on container ffmpeg
- Increase read_timeout since models can take a long time to load
@victorges victorges merged commit d046b05 into main Nov 2, 2024
4 checks passed
@victorges victorges deleted the ja/add-trickle branch November 2, 2024 04:31
@j0sh j0sh mentioned this pull request Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants