Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: always save vips output in srgb colourspace #45

Merged
merged 2 commits into from
Dec 13, 2024

Conversation

knarewski
Copy link
Contributor

Background

GdkPixbuf-based image processing can take over 1GB of memory for processing a single high-resolution photo. We've decided to introduce another processor, hoping that it'll improve Morandi's memory profile and performance.

Problems

By default, Vips processor retains the input colourspace when saving, which is inconsistent with how GdkPixbuf's version works

Solution

Cast to sRGB before saving if needed

Notes

  • I've also noticed unrelated spec being broken, because the image processor wasn't set (so the same spec ran for GdkPixbuf twice)

…ty settings

Previously the test was performed on pixbuf twice instead of using the relevant processor
That is a default behaviour for GdkPixbuf, so mirroring it in vips for better compatibility
@knarewski knarewski requested a review from a team December 12, 2024 14:30
@knarewski knarewski merged commit 093a0b0 into master Dec 13, 2024
15 checks passed
@knarewski knarewski deleted the feat-support-non-rgb-input branch December 13, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants