Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add vips rotate #38

Merged
merged 1 commit into from
Dec 5, 2024
Merged

feat: add vips rotate #38

merged 1 commit into from
Dec 5, 2024

Conversation

knarewski
Copy link
Contributor

Background

GdkPixbuf-based image processing can take over 1GB of memory for processing a single high-resolution photo. We've decided to introduce another processor, hoping that it'll improve Morandi's memory profile and performance.

Problems

Vips processor doesn't support rotation

Solution

Add support for rotation

Pixbuf vs Vips comparison

180 degrees rotation (left - pixbuf, right - vips), mean average error: 0.0080234

Other images can be compared by opening files with identical names in spec/fixtures/reference_images/ and spec/fixtures/reference_images/vips/

@knarewski knarewski force-pushed the feat-add-vips-crop branch 2 times, most recently from 7eeedc9 to c0925db Compare November 29, 2024 12:46
@knarewski knarewski force-pushed the feat-add-vips-rotate branch from 97a3e1b to 865de1a Compare November 29, 2024 12:48
@knarewski knarewski marked this pull request as ready for review November 29, 2024 15:05
@knarewski knarewski requested a review from a team November 29, 2024 15:05
Base automatically changed from feat-add-vips-crop to master December 2, 2024 09:47
Reference images diffs:
- plasma-rotated-90 - MAE (Mean Average Error): 0.00802462
- plasma-rotated-180 - MAE: 0.0080234
- plasma-rotated-270 - MAE: 0.00750394
@knarewski knarewski force-pushed the feat-add-vips-rotate branch from 865de1a to c38b981 Compare December 2, 2024 11:09
Copy link
Contributor

@MrLukeSmith MrLukeSmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@knarewski knarewski merged commit 4328af3 into master Dec 5, 2024
15 checks passed
@knarewski knarewski deleted the feat-add-vips-rotate branch December 5, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants