feat: add colour filters to vips image processor #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
feat-introduce-vips-image-processor
to
master
November 27, 2024 08:09
Notes:
- the filter matrices are designed for RGB, so the image needs to use that colourspace
- the recomb call effectively converts image to grayscale; there are potentially more elegant
and efficient ways to achieve similar result (eg img.colourspace('b-w')); this solution was chosen to preserve
the same grayscale formula as used in GdkPixbuf-based processor
knarewski
force-pushed
the
feat-add-vips-colour-filters
branch
from
3f29da4 to
fd87f71
Compare
Surge9
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
GdkPixbuf-based image processing can take over 1GB of memory for processing a single high-resolution photo. We've decided to introduce another processor hoping that it'll improve Morandi's memory profile and performance.
Problems
Vips processor doesn't support colour filters
Solution
Add support for colour filters
Notes
img.colourspace('b-w')); this solution was chosen to preserve the same grayscale formula as used in GdkPixbuf-based processor, may be reevaluated laterPixbuf vs Vips comparison
0.0001850.0000002Other images can be compared by opening files with identical names in
spec/fixtures/reference_images/andspec/fixtures/reference_images/vips/