Send analytics events #216
Conversation
pkg/sip/types.go
Outdated
| @@ -60,15 +74,38 @@ const ( | |||
| type URI struct { | |||
| User string | |||
| Host string | |||
| Port uint16 | |||
There was a problem hiding this comment.
Why adding a separate port, if it's already in Addr?
There was a problem hiding this comment.
If the Host field ends up containing a hostname and port, not an ip address, the Addr argument will be invalid (the preexisting line netip.AddrPortFrom(u.Addr.Addr(), uint16(port)) will return "Invalid AddPort", with no port field if u.Addr.Addr() is invalid).
There was a problem hiding this comment.
I also thought that it's the case, but it will still work if we test port separately from the address. addrport.IsValid() always returns addrport.Addr().IsValid().
But if you think it's inconvenient to use that separately, we could change the field type to netip.Addr and add a AddrPort/SetAddrPort helper methods.
pkg/sip/types.go
Outdated
| url := &livekit.SIPUri{ | ||
| User: u.User, | ||
| Host: u.GetHost(), | ||
| Port: fmt.Sprintf("%d", u.GetPort()), |
There was a problem hiding this comment.
This will change after updating to livekit/protocol#869
There was a problem hiding this comment.
Sure. I'll update
No description provided.