Add audio encryption/decryption utilities #573
Conversation
|
|
Co-authored-by: lukasIO <[email protected]>
| unencrypted_audio_bytes = 1 | ||
| ) | ||
|
|
||
| var ErrIncorrectKeyLength = errors.New("incorrect key length for encryption/decryption") |
There was a problem hiding this comment.
sorry, very late on this review. In case you get a chance, suggest a style like
var (
Err1 =
Err2 =
)
That makes it easier to read.
There was a problem hiding this comment.
ok, I can change in the next PR, I was going to add example on how to use the utilities separately.
|
|
||
| key, err := DeriveKeyFromBytes(inputSecret) | ||
| assert.Nil(t, err) | ||
| assert.Equal(t, expectedKey, key) |
There was a problem hiding this comment.
Can we switch these to require package? LK has been using it in other repos.
There was a problem hiding this comment.
sounds good, I'll have a look
| copy(cipherText, sample[cipherTextStart:cipherTextStart+cipherTextLength]) | ||
|
|
||
| // setup AES | ||
| aesCipher, err := aes.NewCipher(key) |
There was a problem hiding this comment.
Is there any performance penalty to creating this for every sample? Can this be created in track context and re-used?
There was a problem hiding this comment.
I've tried to keep it as separate and self-contained as possible without the need to instantiate anything separately to use it. I believe the AES operations are highly optimized in Go with the use of Go Assembler, but I'll see if I can run a quick benchmark with and without the cipher reuse.
Added:
client-sdk-jswith the same inputsclient-sdk-jsChanged:
sifTrailerfrom joinResponse so thatsifTrailercan be passed later to Decryption utility