Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add OnTranscription Handler #571

Merged
merged 2 commits into from
Dec 4, 2024
Merged

Add OnTranscription Handler #571

merged 2 commits into from
Dec 4, 2024

Conversation

duongnv129
Copy link
Contributor

This PR adds an OnTranscription handler to manage transcription events in the Go SDK, following the implementation in livekit/client-sdk-js#1119 for consistency.

Key Updates:

  • Implements OnTranscription callback.
  • Matches JavaScript SDK behavior.
  • Enhances transcription handling in the Go SDK.

@CLAassistant
Copy link

CLAassistant commented Dec 1, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@duongnv129 duongnv129 mentioned this pull request Dec 1, 2024
Open
davidzhao
davidzhao reviewed Dec 4, 2024
View reviewed changes
room.go Outdated Show resolved Hide resolved
davidzhao
davidzhao approved these changes Dec 4, 2024
View reviewed changes
Copy link
Member

@davidzhao davidzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks for the PR!

@davidzhao davidzhao merged commit 59f3bc1 into livekit:main Dec 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidzhao davidzhao davidzhao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@duongnv129 @CLAassistant @davidzhao