Allow setting disconnect reason. Map SIP reasons. #537
Conversation
| "canReconnect", leave.GetCanReconnect(), | ||
| ) | ||
| if e.OnDisconnected != nil { | ||
| e.OnDisconnected(LeaveRequested) | ||
| e.OnDisconnected(GetDisconnectionReason(reason)) | ||
| } |
There was a problem hiding this comment.
not about this PR, but we need to update this SDK to support LeaveRequest.Action at some point
There was a problem hiding this comment.
Will add a TODO here 👍
| LeaveRequested DisconnectionReason = "leave requested by room" | ||
| UserUnavailable DisconnectionReason = "remote user unavailable" | ||
| RejectedByUser DisconnectionReason = "rejected by remote user" | ||
| Failed DisconnectionReason = "connection to room failed" |
There was a problem hiding this comment.
Would be nice to move protocol DisconnectReason -> string to common place like protocol and use it both here and also in livekit server. Comment not related to this PR.
There was a problem hiding this comment.
Actually this might be the right time. Since I need to update both anyway, I could do it as well.
The only problem is that OnDisconnected callback accepts this string type currently and changing it to something else would not be backward-compatible. Will have to add a new callback, probably.
There was a problem hiding this comment.
Do you know if somebody is telling on that string value? Guess it is impossible to say.
We can keep the same string for the two existing there and add the rest.
There was a problem hiding this comment.
Oh string type. Got it. Yeah that's messy
dennwc
force-pushed
the
disconnect-reason
branch
from
86ab5c2 to
d259aea
Compare
dennwc
force-pushed
the
disconnect-reason
branch
from
d259aea to
b482794
Compare
Allow setting disconnect reason. Map new SIP disconnect reasons to SDK constants.
Requires livekit/protocol#828