Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix save_to_disk example to work with recent SDK #528

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

typester
Copy link
Member

This pull request fixes the issue described in #465.

The issue occurred because the example code was not updated to reflect recent changes in the SDK. To address this, I updated only the example code, leaving the SDK code unchanged. This ensures that the example works correctly with the latest SDK.

I have verified that the fix works as expected on my local environment.

Connected to room: test - RM_XbLs8ZcGkyXR
Recording track TrackSid("TR_AMPtcW3Rt7zTNZ")
Done

Copy link
Contributor

ilo-nanpa bot commented Dec 16, 2024

it seems like you haven't added any nanpa changeset files to this PR.

if this pull request includes changes to code, make sure to add a changeset, by writing a file to .nanpa/<unique-name>.kdl:

minor type="added" "Introduce frobnication algorithm"

refer to the manpage for more information.

@CLAassistant
Copy link

CLAassistant commented Dec 16, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@bcherry bcherry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@bcherry bcherry requested a review from theomonnom December 16, 2024 21:47
@bcherry
Copy link
Contributor

bcherry commented Dec 16, 2024

@typester did you confirm whether any other examples are similarly broken? The original issue says that "most" were broken.

@typester
Copy link
Member Author

@typester did you confirm whether any other examples are similarly broken? The original issue says that "most" were broken.

Yes, I've confirmed some other examples have same issues. I will fix these as well as separated pull requests.

@typester
Copy link
Member Author

typester commented Dec 17, 2024

@bcherry

I tested each example listed in this repository's README:

I plan to check the mobile example tomorrow. Testing the examples was helpful for me as it allowed me to see how this SDK is used in practice.

@davidzhao davidzhao merged commit ca95b54 into livekit:main Dec 17, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants