Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(webrtc-sys): bump to m125_release #505

Merged
merged 10 commits into from
Dec 11, 2024
Merged

chore(webrtc-sys): bump to m125_release #505

merged 10 commits into from
Dec 11, 2024

Conversation

nbsp
Copy link
Member

@nbsp nbsp commented Dec 3, 2024

No description provided.

@nbsp nbsp requested a review from theomonnom December 3, 2024 13:41
@nbsp nbsp marked this pull request as ready for review December 5, 2024 06:45
@nbsp nbsp force-pushed the nbsp/bump/webrtc-m125 branch from 1768852 to 496d870 Compare December 5, 2024 11:44
Copy link
Member

@theomonnom theomonnom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise lgtm!

// ABSL_USES_STD_OPTIONAL.

-#define ABSL_OPTION_USE_STD_OPTIONAL 2
+#define ABSL_OPTION_USE_STD_OPTIONAL 0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you send the error you were seeing

Copy link
Member Author

@nbsp nbsp Dec 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

error: no matching member function for call to 'emplace'

this debian packaging chromium commit has some context: revyos/chromium@8b5cf4e#diff-739ae0c2a9db7abdfc731d0263d45af539867f89c09cd7c4e04973b2edb47cf6R13

@nbsp nbsp force-pushed the nbsp/bump/webrtc-m125 branch from 9c50535 to 93283db Compare December 11, 2024 17:49
@nbsp nbsp merged commit a1b926e into main Dec 11, 2024
2 of 5 checks passed
@nbsp nbsp deleted the nbsp/bump/webrtc-m125 branch December 11, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants