Fix obvious errors from the CI #500
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
``` warning: /Users/runner/work/rust-sdks/rust-sdks/livekit/Cargo.toml: `default-features` is ignored for livekit-api, since `default-features` was not specified for `workspace.dependencies.livekit-api`, this could become a hard error in the future warning: /Users/runner/work/rust-sdks/rust-sdks/livekit/Cargo.toml: `default-features` is ignored for livekit-runtime, since `default-features` was not specified for `workspace.dependencies.livekit-runtime`, this could become a hard error in the future ``` CI error: https://github.com/livekit/rust-sdks/actions/runs/12035060003/job/33553117641
``` warning: virtual workspace defaulting to `resolver = "1"` despite one or more workspace members being on edition 2021 which implies `resolver = "2"` note: to keep the current resolver, specify `workspace.resolver = "1"` in the workspace root's manifest note: to use the edition 2021 resolver, specify `workspace.resolver = "2"` in the workspace root's manifest note: for more details see https://doc.rust-lang.org/cargo/reference/resolver.html#resolver-versions ``` error from the CI: https://github.com/livekit/rust-sdks/actions/runs/12035060003/job/33553117641#step:5:7
|
Apologies for that! We are planning to hire additional team members specifically to dedicate more time and resources to the development of the Rust SDKs. |
|
No worries, the biggest concern is uncertainty and absence of answers (e.g. #467 and #465) but it all seems to become better. We're @ Zed are very interested to have a better screenshare quality (presumably #488 handles that) but are somewhat blocked, so would you mind if we submit a series of PRs to get things more stable? We can start from here and use a bit of your guidance for the later PRs (as not everything is as straightforwards as here) + the reviews and merge 🙂 Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent CI runs look very intimidating and worse, there are certain errors that are there for months.
The PR attempts to handle a few of them as a probe, to see the reception.
Overall, it's interested to hear your plans on tackling this all, as it seems quite dangerous to keep that many errors during feature development, and pretty impossible to use the library with all that mess in it.