Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more explicit url errors #281

Merged
merged 2 commits into from
Jan 11, 2024
Merged

more explicit url errors #281

merged 2 commits into from
Jan 11, 2024

Conversation

theomonnom
Copy link
Member

No description provided.

@theomonnom theomonnom requested a review from davidzhao January 11, 2024 07:57
}

// Automatically switch to websocket scheme when using user is providing http(s) scheme
if lk_url.scheme() == "https" {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome!

@theomonnom theomonnom merged commit 493ea80 into main Jan 11, 2024
11 of 16 checks passed
@theomonnom theomonnom deleted the theo/explicit-url-errors branch January 11, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants