android: release audio device module after creating factory

livekit · Jun 21, 2024 · 71da6c7 · 71da6c7
1 parent c8829cb
commit 71da6c7
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 9 deletions.
diff --git a/android/src/main/java/com/oney/WebRTCModule/WebRTCModule.java b/android/src/main/java/com/oney/WebRTCModule/WebRTCModule.java
@@ -102,6 +102,9 @@ public WebRTCModule(ReactApplicationContext reactContext) {
                            .setVideoDecoderFactory(decoderFactory)
                            .createPeerConnectionFactory();
 
+        // PeerConnectionFactory now owns the adm native pointer, and we don't need it anymore.
+        adm.release();
+
         // Saving the encoder and decoder factories to get codec info later when needed.
         mVideoEncoderFactory = encoderFactory;
         mVideoDecoderFactory = decoderFactory;
@@ -116,14 +119,6 @@ public String getName() {
         return "WebRTCModule";
     }
 
-    @Override
-    public void onCatalystInstanceDestroy() {
-        if (mAudioDeviceModule != null) {
-            mAudioDeviceModule.release();
-        }
-        super.onCatalystInstanceDestroy();
-    }
-
     private PeerConnection getPeerConnection(int id) {
         PeerConnectionObserver pco = mPeerConnectionObservers.get(id);
         return (pco == null) ? null : pco.getPeerConnection();

diff --git a/examples/GumTestApp/package.json b/examples/GumTestApp/package.json
@@ -13,7 +13,7 @@
   "dependencies": {
     "react": "18.2.0",
     "react-native": "0.71.4",
-    "react-native-webrtc": "*"
+    "@livekit/react-native-webrtc": "*"
   },
   "devDependencies": {
     "@babel/core": "^7.20.0",