Allow mapping all SIP headers to attributes. #920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 72ab163 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR 💥 An error occurred when fetching the changed packages and changesets in this PR |
dennwc
force-pushed
the
sip-all-headers
branch
from
01bc9a7 to
9ec29af
Compare
| @@ -194,6 +200,7 @@ message SIPInboundTrunkInfo { | |||
| // Map LiveKit attributes to SIP X-* headers when sending BYE or REFER requests. | |||
| // Keys are the names of attributes and values are the names of X-* headers they will be mapped to. | |||
| map<string, string> attributes_to_headers = 14; | |||
| SIPHeaderOptions include_headers = 15; | |||
There was a problem hiding this comment.
I think we may need to add some documentation here, as the interaction of attributes_to_headers and include_headers may not be obvious.
There was a problem hiding this comment.
Done! Please let me know if there's anything else missing.
dennwc
force-pushed
the
sip-all-headers
branch
from
9ec29af to
72ab163
Compare
biglittlebigben
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.