Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to webrtc v4 #899

Merged
merged 1 commit into from
Nov 28, 2024
Merged

upgrade to webrtc v4 #899

merged 1 commit into from
Nov 28, 2024

Conversation

cnderrauber
Copy link
Contributor

No description provided.

@cnderrauber cnderrauber requested a review from a team November 28, 2024 07:13
Copy link
Contributor

@boks1971 boks1971 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this work with SIP also? Are you making necessary changes there also?

@boks1971
Copy link
Contributor

Guess, SIP can stay on older version till it is ported.

@cnderrauber
Copy link
Contributor Author

Would this work with SIP also? Are you making necessary changes there also?

@boks1971 Will pion/webrtc/v4 break sip?

@boks1971
Copy link
Contributor

Would this work with SIP also? Are you making necessary changes there also?

@boks1971 Will pion/webrtc/v4 break sip?

Don't think so. But, I am not aware of changes needed. Just wanted to make sure that other parts of the system do not need to maintain an alt branch for long.

For example, if SIP requires a bunch of changes for v4 (same with Go Server SDK) and porting over is going to take long, it will have to be on alt branch of this repo for that period of time if it needs protocol changes. That could be a bit of a pain. So, wanted to understand the impact.

@boks1971
Copy link
Contributor

I guess ingress/egress all use pion. So, they will have to port or work off of an alt branch till it is ported.

@cnderrauber
Copy link
Contributor Author

Would this work with SIP also? Are you making necessary changes there also?

@boks1971 Will pion/webrtc/v4 break sip?

Don't think so. But, I am not aware of changes needed. Just wanted to make sure that other parts of the system do not need to maintain an alt branch for long.

For example, if SIP requires a bunch of changes for v4 (same with Go Server SDK) and porting over is going to take long, it will have to be on alt branch of this repo for that period of time if it needs protocol changes. That could be a bit of a pain. So, wanted to understand the impact.

It depends on how it use the dependency, will check it. I have a list of repo to upgrade includes protocol mediatransportutils backend-common go-sdk livekit and cloud to update them together, if there is other repo not included then tell me, I'll update them.

@boks1971
Copy link
Contributor

Would this work with SIP also? Are you making necessary changes there also?

@boks1971 Will pion/webrtc/v4 break sip?

Don't think so. But, I am not aware of changes needed. Just wanted to make sure that other parts of the system do not need to maintain an alt branch for long.
For example, if SIP requires a bunch of changes for v4 (same with Go Server SDK) and porting over is going to take long, it will have to be on alt branch of this repo for that period of time if it needs protocol changes. That could be a bit of a pain. So, wanted to understand the impact.

It depends on how it use the dependency, will check it. I have a list of repo to upgrade includes protocol mediatransportutils backend-common go-sdk livekit and cloud to update them together, if there is other repo not included then tell me, I'll update them.

Thank you. I think ingress, egress and sip are the other three.

@cnderrauber cnderrauber merged commit b738aed into main Nov 28, 2024
3 checks passed
@cnderrauber cnderrauber deleted the webrtc_v4 branch November 28, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants