Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map participant attributes to SIP headers #893

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Map participant attributes to SIP headers #893

merged 1 commit into from
Nov 27, 2024

Conversation

dennwc
Copy link
Contributor

@dennwc dennwc commented Nov 25, 2024

No description provided.

@dennwc dennwc requested a review from a team November 25, 2024 11:36
@dennwc dennwc self-assigned this Nov 25, 2024
Copy link

changeset-bot bot commented Nov 25, 2024

🦋 Changeset detected

Latest commit: 8a1df6e

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR
Some errors occurred when validating the changesets config:
The package or glob expression "github.com/livekit/protocol" specified in the `fixed` option does not match any package in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

@dennwc dennwc merged commit 9e70d56 into main Nov 27, 2024
3 checks passed
@dennwc dennwc deleted the sip-attrs2headers branch November 27, 2024 12:30
@github-actions github-actions bot mentioned this pull request Nov 27, 2024
@marrold
Copy link

marrold commented Dec 10, 2024

Hi, is this working and filtered down to the other components? Perhaps I've read it wrong but I thought it would allow to map meta data to X- headers in SIP requests

Here's my outbound trunk config:

{
  "trunk": {
    "name": "pbx",
    "address": "127.0.0.1:5070",
    "numbers": ["6002"],
    "auth_username": "6002",
    "auth_password": "blah",
    "attributes_to_headers": {
      "play_dialtone": "X-Sausage"
    }
  }
}

but the attributes_to_headers aren't shown:

matthew@DESKTOP-RJ4LK0J:~/devel/hackfest-pbx$ lk --project voco-test sip outbound list
Using project [voco-test]
┌─────────────────┬──────┬────────────────┬───────────┬─────────┬────────────────┬───────────────────────┬──────────┐
│ SipTrunkID      │ Name │ Address        │ Transport │ Numbers │ Authentication │ Headers               │ Metadata │
├─────────────────┼──────┼────────────────┼───────────┼─────────┼────────────────┼───────────────────────┼──────────┤
│ ST_Tbg3GWge44LE │ pbx  │ 127.0.0.1:5070 │ AUTO      │ 6002    │ 6002 / ****    │ map[], map[] │          │
└─────────────────┴──────┴────────────────┴───────────┴─────────┴────────────────┴───────────────────────┴──────────┘

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants