Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EgressInfo helpers #880

Merged
merged 4 commits into from
Nov 12, 2024
Merged

EgressInfo helpers #880

merged 4 commits into from
Nov 12, 2024

Conversation

frostbyte73
Copy link
Member

No description provided.

@frostbyte73 frostbyte73 requested a review from a team November 8, 2024 20:27
Copy link

changeset-bot bot commented Nov 8, 2024

⚠️ No Changeset found

Latest commit: bb036e3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR
Some errors occurred when validating the changesets config:
The package or glob expression "github.com/livekit/protocol" specified in the `fixed` option does not match any package in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

e.Status = EgressStatus_EGRESS_FAILED
e.UpdatedAt = time.Now().UnixNano()
e.Error = MsgBackupUsed
e.ErrorCode = int32(http.StatusPermanentRedirect)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How will we communicate the case where a segmented file egress eventually ended as failure, but where some segments have failed to upload as well? Customers may want to download whatever segments are available, but will need a way to see that some are only available on the backup storage.

What I'm getting at is that I'm wondering if backup status should be orthogonal to the egress status/error state.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, I think we'll need to add something else because even a separate backup_used state wouldn't cover that

@frostbyte73 frostbyte73 merged commit 391b78f into main Nov 12, 2024
3 checks passed
@frostbyte73 frostbyte73 deleted the egress-info-helpers branch November 12, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants