-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EgressInfo helpers #880
EgressInfo helpers #880
Conversation
|
livekit/livekit_egress.go
Outdated
e.Status = EgressStatus_EGRESS_FAILED | ||
e.UpdatedAt = time.Now().UnixNano() | ||
e.Error = MsgBackupUsed | ||
e.ErrorCode = int32(http.StatusPermanentRedirect) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How will we communicate the case where a segmented file egress eventually ended as failure, but where some segments have failed to upload as well? Customers may want to download whatever segments are available, but will need a way to see that some are only available on the backup storage.
What I'm getting at is that I'm wondering if backup status should be orthogonal to the egress status/error state.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True, I think we'll need to add something else because even a separate backup_used state wouldn't cover that
No description provided.