Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

krisp for outbound trunks #868

Merged
merged 6 commits into from
Oct 25, 2024
Merged

krisp for outbound trunks #868

merged 6 commits into from
Oct 25, 2024

Conversation

frostbyte73
Copy link
Member

No description provided.

@frostbyte73 frostbyte73 requested a review from a team October 24, 2024 22:49
Copy link

changeset-bot bot commented Oct 24, 2024

⚠️ No Changeset found

Latest commit: 4df0489

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR
Some errors occurred when validating the changesets config:
The package or glob expression "github.com/livekit/protocol" specified in the `fixed` option does not match any package in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

@@ -232,6 +232,8 @@ message SIPOutboundTrunkInfo {
// Map SIP X-* headers from 200 OK to SIP participant attributes.
// Keys are the names of X-* headers and values are the names of attributes they will be mapped to.
map<string, string> headers_to_attributes = 10;

bool krisp_enabled = 11;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we set this on the CreateSIPParticipant API instead? For outbound calls, it would give better control if it could be enabled or disabled for each call.

for inbound calls, since there's no explicit APIs, we'd have to leave any customizable options on the trunk

protobufs/livekit_sip.proto Outdated Show resolved Hide resolved
@frostbyte73 frostbyte73 merged commit 32abc4d into main Oct 25, 2024
1 check passed
@frostbyte73 frostbyte73 deleted the krisp-outbound-trunk branch October 25, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants