Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add callee dispatch rule type. #798

Merged
merged 1 commit into from
Aug 31, 2024
Merged

Add callee dispatch rule type. #798

merged 1 commit into from
Aug 31, 2024

Conversation

dennwc
Copy link
Contributor

@dennwc dennwc commented Aug 31, 2024

Add a new Dispatch Rule type that selects a room name based on a callee.

Creating an empty Callee dispatch rule allow mapping <room>@xyz.sip.livekit.cloud to the <room>. Similarly to Individual rule type (which we should have called "Caller") it also allows setting a prefix for the room name.

@dennwc dennwc requested review from davidzhao and a team August 31, 2024 07:55
@dennwc dennwc self-assigned this Aug 31, 2024
Copy link

changeset-bot bot commented Aug 31, 2024

🦋 Changeset detected

Latest commit: 204c7ee

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR
Some errors occurred when validating the changesets config:
The package or glob expression "github.com/livekit/protocol" specified in the `fixed` option does not match any package in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

@dennwc dennwc force-pushed the sip-dispatch-callee branch from d5ac6da to 204c7ee Compare August 31, 2024 07:58
Copy link
Member

@davidzhao davidzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@dennwc dennwc merged commit 2454665 into main Aug 31, 2024
3 checks passed
@dennwc dennwc deleted the sip-dispatch-callee branch August 31, 2024 16:33
@github-actions github-actions bot mentioned this pull request Aug 31, 2024
paulwe pushed a commit that referenced this pull request Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants